More memory efficient bitset using int8 instead of bool type. Solving issue #21 . Thank you @delaneyj #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Np, though a roaring bitmap will be even more efficient for sparse bitmaps and has simd built in |
|
@delaneyj I don't doubt it. We can work on a PR with a roaring bitmap swap out and compare the performance. Surely it could be greater. |
|
There will surely be positives and negatives to both. We can even add another option so if you don't want bloom you can set bitmap; But can't have both kinda thing. That would be very cool. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More memory efficient bitset using int8 instead of bool type. Solving issue #21 . Thank you @delaneyj