Use nullish coalescing where appropriate

start · Oct 3, 2020 · 520c550 · 520c550
1 parent 4bbc296
commit 520c550
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 7 deletions.
diff --git a/src/Implementation/Parsing/Inline/Tokenizing/BacktrackedConventionHelper.ts b/src/Implementation/Parsing/Inline/Tokenizing/BacktrackedConventionHelper.ts
@@ -18,7 +18,7 @@ export class BacktrackedConventionHelper {
   }
 
   hasFailed(convention: ConventionVariation, markupIndex: number): boolean {
-    const failedConventions = (this.failedConventionsByMarkupIndex[markupIndex] || [])
+    const failedConventions = (this.failedConventionsByMarkupIndex[markupIndex] ?? [])
     return failedConventions.some(failedConvention => failedConvention === convention)
   }
 }

diff --git a/src/Implementation/Rendering/Html/HtmlRenderer.ts b/src/Implementation/Rendering/Html/HtmlRenderer.ts
@@ -455,7 +455,7 @@ export class HtmlRenderer extends Renderer {
         args.revealableSyntaxNode.children,
         { role: 'alert' })
 
-    const attrsForOuterContainer = args.attrsForOuterContainer || {}
+    const attrsForOuterContainer = args.attrsForOuterContainer ?? {}
 
     attrsForOuterContainer.class =
       cssClassAttrValue('revealable')

diff --git a/src/Implementation/Up.ts b/src/Implementation/Up.ts
@@ -83,11 +83,11 @@ export class Up {
   }
 
   private getParsingSettings(changes: Settings.Parsing | undefined): NormalizedSettings.Parsing {
-    return this.settings.withChanges({ parsing: changes || {} }).parsing
+    return this.settings.withChanges({ parsing: changes ?? {} }).parsing
   }
 
   private getRenderingSettings(changes: Settings.Rendering | undefined): NormalizedSettings.Rendering {
-    return this.settings.withChanges({ rendering: changes || {} }).rendering
+    return this.settings.withChanges({ rendering: changes ?? {} }).rendering
   }
 }
 
@@ -98,7 +98,7 @@ export interface DocumentAndTableOfContentsHtml {
 }
 
 function getNonNullSettings(settings: Settings | undefined): Settings {
-  return settings || {
+  return settings ?? {
     parsing: {},
     rendering: {}
   }

diff --git a/src/Test/Parsing/Helpers.ts b/src/Test/Parsing/Helpers.ts
@@ -42,10 +42,10 @@ export function expectEveryPermutationOfBrackets(
 ): void {
   const { toProduce, settings } = args
 
-  const precededBy = args.precededBy || ''
+  const precededBy = args.precededBy ?? ''
 
   const segments = args.bracketedSegments.map(segment => ({
-    prefixes: segment.prefixes || [''],
+    prefixes: segment.prefixes ?? [''],
     text: segment.text
   }))