Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Persistent volume for incognito browsing #417

Open
BenKan opened this issue Aug 24, 2024 · 3 comments
Open

[Feature] Persistent volume for incognito browsing #417

BenKan opened this issue Aug 24, 2024 · 3 comments
Labels
plugin-idea Feature requests that are better served as a plugin

Comments

@BenKan
Copy link

BenKan commented Aug 24, 2024

If I set the volume while not incognito browsing, stashapp recalls my volume e.g. 50%. Contrary to that, using an incognito browser, the volume is not saved and is always at 100%.

It would be great, if the volume setting is remembered even for incognito browsing.

@Gykes
Copy link

Gykes commented Aug 24, 2024

Correct me if I'm wrong here.

When you go into incognito all settings/cookies are lost/forgotten? If I'm not mistaken that's the point of incognito. It wouldn't be possible to make the sound level stick without altering the point of incognito, right?

@echo6ix
Copy link

echo6ix commented Aug 24, 2024

Correct me if I'm wrong here.

When you go into incognito all settings/cookies are lost/forgotten? If I'm not mistaken that's the point of incognito. It wouldn't be possible to make the sound level stick without altering the point of incognito, right?

You're correct.

He's basically asking for persistent volume across devices/browsers, which I think is a bad idea. Users lose to the ability to vary volume per device/browser, resulting in an inconsistent user experience. This is an obvious deficiency so maybe he just wants to implement a toggle setting to enable this specific use case. I think this would be better suited for a plugin FR.

@Gykes
Copy link

Gykes commented Aug 24, 2024

Correct me if I'm wrong here.
When you go into incognito all settings/cookies are lost/forgotten? If I'm not mistaken that's the point of incognito. It wouldn't be possible to make the sound level stick without altering the point of incognito, right?

You're correct.

He's basically asking for persistent volume across devices/browsers, which I think is a bad idea. Users lose to the ability to vary volume per device/browser, resulting in an inconsistent user experience. This is an obvious deficiency so maybe he just wants to implement a toggle setting to enable this specific use case. I think this would be better suited for a plugin FR.

Agreed, most incognito users want anonymity and I feel like this could potentially pull from that. My vote is Stash shouldn't be changing how incognito works. Plugin idea from me as well.

@DogmaDragon DogmaDragon transferred this issue from stashapp/stash Aug 24, 2024
@DogmaDragon DogmaDragon added the plugin-idea Feature requests that are better served as a plugin label Aug 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin-idea Feature requests that are better served as a plugin
Projects
None yet
Development

No branches or pull requests

4 participants