Skip to content

Commit

Permalink
update cross-compiler.sh
Browse files Browse the repository at this point in the history 
fixup
  • Loading branch information
@Leopere
Leopere authored Nov 16, 2019
1 parent fa6da54 commit 3e13103
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion scripts/cross-compile.sh
View file
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,4 @@ RASPPI="GOOS=linux GOARCH=arm GOARM=5 CC=arm-linux-gnueabi-gcc packr2 build -o d

COMMAND="$SETUP $WINDOWS $DARWIN $LINUX $RASPPI"

docker run --rm --mount type=bind,source="$(pwd)",target=/stash -w /stash stashapp/compiler /bin/bash -c "$COMMAND"
docker run --rm --mount type=bind,source="$(pwd)",target=/stash -w /stash stashapp/stash:compiler /bin/bash -c "$COMMAND"

3 comments on commit 3e13103

@WithoutPants
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The travis file still has docker pull stashappdev/compiler

@Leopere
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well now we actually have https://hub.docker.com/r/stashapp/compiler

@WithoutPants
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My point is that travis now pulls a docker image that it doesn't use:
From latest build:

$ docker pull stashappdev/compiler
Using default tag: latest
latest: Pulling from stashappdev/compiler
...
$ sh ./scripts/cross-compile.sh ${STASH_VERSION}
Unable to find image 'stashapp/stash:compiler' locally
compiler: Pulling from stashapp/stash

So travis needs to change its docker pull command to use stashapp/stash:compiler, or just remove it altogether.

Please sign in to comment.