Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Various pwa manifests fixes #5669

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

miawgogo
Copy link

@miawgogo miawgogo commented Feb 19, 2025

Adds a few fixes to the manifest file and adds a square SVG so that hopefully firefox mobile allows it to be used as a PWA.

closes #5668

@DogmaDragon
Copy link
Collaborator

DogmaDragon commented Feb 19, 2025

Chromium based browsers doesn't support SVG icons. https://issues.chromium.org/issues/41057033

@miawgogo
Copy link
Author

Chromium based browsers doesn't support SVG icons. https://issues.chromium.org/issues/41057033

I have still included both of the .ico and .png versions in the manifest, so even then that shouldnt be an issue, and from my local testing in chromium, it seems to behave and either grabs the png/ico version or the issue mentioned only applies to extentions

even though devtools complains
@miawgogo
Copy link
Author

miawgogo commented Feb 19, 2025

yeah, that chromium bug is only for extensions, Progressive Web Apps seem unaffected as i have just quickly tested it by removing the raster formats and only having a SVG and it still installs sucessfully

Dev Tools:
image

Install Modal:
image

app title bar:
image

App Browser:
image

@miawgogo
Copy link
Author

miawgogo commented Feb 19, 2025

Also tested on firefox(made a temp subdomain to give the dev server a https cert) these changes have fixed the install issues

@miawgogo miawgogo marked this pull request as draft February 19, 2025 17:37
@miawgogo
Copy link
Author

miawgogo commented Feb 19, 2025

Moved it into draft, i decided i want the icon to be maskable. but also to make it close to the apple icon: I currently have this example i quickly made

stash_icon

@miawgogo miawgogo marked this pull request as ready for review February 19, 2025 18:08
@miawgogo miawgogo requested a review from DogmaDragon February 19, 2025 18:10
@miawgogo
Copy link
Author

miawgogo commented Feb 19, 2025

i should clarify that the sudden icon change was mainly driven by how the icon looked on my phone without a background

adding a solid square background should help prevent the icon being unrecognisable

@DogmaDragon DogmaDragon removed their request for review February 19, 2025 20:49
@DogmaDragon
Copy link
Collaborator

Thanks for answering my questions. But I'm not a developer, sorry. One of them will need to review and merge the pull request.

Make the background colour the same as the background as stash
@WithoutPants WithoutPants added chore Pull requests for refactoring and admin work bug Something isn't working labels Feb 21, 2025
@WithoutPants WithoutPants added this to the Version 0.28.0 milestone Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working chore Pull requests for refactoring and admin work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] PWA is unavalible on some platforms and browsers due to manifest requirements chaging
3 participants