Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ImageGenerator throws http error #10788

Closed
indykoning opened this issue Sep 11, 2024 · 0 comments · Fixed by #10786
Closed

ImageGenerator throws http error #10788

indykoning opened this issue Sep 11, 2024 · 0 comments · Fixed by #10786

Comments

@indykoning
Copy link
Contributor

indykoning commented Sep 11, 2024

Bug description

When using the ImageGenerator manually (or using packages such as https://github.com/spatie/statamic-responsive-images)
the imageGenerator throws a http not found exception.
This can cause several problems in debugging and using the ImageGenerator.
e.g. using https://github.com/spatie/statamic-responsive-images to pregenerate responsive images, a single missing image will cause your entire page to return a 404 instead of simply not rendering the image.

What i would expect is for it to throw it's appropriate error so the controller or caller can decide how to handle the specific error.

How to reproduce

Remove an image from the filesystem, and either attempt to generate that image via tinker, or via https://github.com/spatie/statamic-responsive-images

Logs

No response

Environment

.

Installation

Fresh statamic/statamic site via CLI

Additional details

caused by: https://github.com/statamic/cms/pull/3450/files#diff-a241fa0e16c263728c96b0f5b5b590e06e14a79e2e7260a3501bba22ceb88755R152
Fixed by: #10786
related: spatie/statamic-responsive-images#249

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant