You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When using the ImageGenerator manually (or using packages such as https://github.com/spatie/statamic-responsive-images)
the imageGenerator throws a http not found exception.
This can cause several problems in debugging and using the ImageGenerator.
e.g. using https://github.com/spatie/statamic-responsive-images to pregenerate responsive images, a single missing image will cause your entire page to return a 404 instead of simply not rendering the image.
What i would expect is for it to throw it's appropriate error so the controller or caller can decide how to handle the specific error.
Bug description
When using the ImageGenerator manually (or using packages such as https://github.com/spatie/statamic-responsive-images)
the imageGenerator throws a http not found exception.
This can cause several problems in debugging and using the ImageGenerator.
e.g. using https://github.com/spatie/statamic-responsive-images to pregenerate responsive images, a single missing image will cause your entire page to return a 404 instead of simply not rendering the image.
What i would expect is for it to throw it's appropriate error so the controller or caller can decide how to handle the specific error.
How to reproduce
Remove an image from the filesystem, and either attempt to generate that image via tinker, or via https://github.com/spatie/statamic-responsive-images
Logs
No response
Environment
.
Installation
Fresh statamic/statamic site via CLI
Additional details
caused by: https://github.com/statamic/cms/pull/3450/files#diff-a241fa0e16c263728c96b0f5b5b590e06e14a79e2e7260a3501bba22ceb88755R152
Fixed by: #10786
related: spatie/statamic-responsive-images#249
The text was updated successfully, but these errors were encountered: