-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SiteDefaults are not localizable #289
Comments
We're having the same issue, all the fields say localisable but they're not. This is also the case for the section defaults too. |
Same here! +1 |
This can actually be quite important, we're now content editing a dozen (sub)sites next to an already live main site. Al the sub sites are indexed by Google already, which is causing big problems for SEO of course... We wanted to set them to noindex but that caused all sites to be noindex, panic ensued... 🫨 |
+1 Same here |
Some site default values can be localized using the I realize this is a long-standing issue, but just wanted to say that we definitely have plans to improve multisite support in SEO Pro 👍 |
SiteDefault ("/seo-pro/site-defaults/edit") are NOT localizable.
Blueprint sets some of them (ie. Meta Title, Meta Description, Site Name) as such, but actually it's impossible to translate them.
Furthermore, the yaml file where this data is saved (at least according to the default of the seo-pro config) is located in /content/seo-pro.yaml. This effectively prevents the possibility of locating its content.
The file should be saved in a dedicated folder within
/content
, e.g./content/seo-pro/
, in which the file is saved in the different sites, e.g./content/seo-pro/default/seo-pro.yaml
,/content/seo-pro/french/seo-pro.yaml
,/content/seo-pro/german/seo-pro.yaml
...The
SiteDefaults
class should therefore handle the "cascade" of the values starting from the "default" locale and adding/overwriting the values of the selected locale.Finally, the form to use I think should be the one used eg. in
Globals
, where the field to select theSite
is next to the "Save" button above the form, on the right.The text was updated successfully, but these errors were encountered: