-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Site defaults supporting multisite #352
Site defaults supporting multisite #352
Conversation
This PR still looks like it's a work-in-progress (lots of tests are failing & there's probably more to it than changing the file paths). Going to mark this as a draft for now. |
hi @duncanmcclean |
… laravel versions
@duncanmcclean i have updated the code slightly to support older versions of Laravel, in my enthusiasm i forgot the config()->bool() and config()->string() methods were relatively new |
The tests still seem to be failing, I'm afraid. When this is ready for us to look at, feel free to mark it as "Ready for review". |
I have replaced the logic with regular php versions to support all Laravel versions, local tests ran OK. |
Thanks @mwagena for your work on this! I actually have some in-progress stuff on this front, which handles schema, but I'm also working out the UI in the CP for localizable site defaults as well. Going to close this for now so that we don't introduce two ways of doing the same thing, but I wanted to say I appreciate your PR ❤️ |
out of curiosity, what's the expectation on releasing this? |
@jesseleite What's the estimated time of release of multisite support? |
I don't think we have an ETA, sorry! |
With this PR support is being added for multisite.
Fallback is added when using a config file with path to the yaml file.
output paths will be ./content/seo/sitehandle/defaults.yaml
Closes #289.