Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CircleCI runs integration tests against dev servers, not production builds #11

Open
snario opened this issue May 15, 2020 · 0 comments
Open

Comments

@snario
Copy link
Contributor

snario commented May 15, 2020

This is generally bad practice and if we can use the production builds as targets for our integration tests we could avoid some weird prod-only bugs. Here is a starter diff:

diff --git i/.circleci/config.yml w/.circleci/config.yml
index b79ce6402..92654d53b 100644
--- i/.circleci/config.yml
+++ w/.circleci/config.yml
@@ -463,12 +463,15 @@ workflows:
       - integration-test-rps:
           requires:
             - prepare
+            - build
       - integration-test-web3torrent:
           requires:
             - prepare
+            - build
       - integration-test-web3torrent-with-hub:
           requires:
             - prepare
+            - build
       - release-pull-request:
           requires:
             - prepare
diff --git i/bin/start-servers.sh w/bin/start-servers.sh
index 3cf9e9b51..6fb1c7c50 100755
--- i/bin/start-servers.sh
+++ w/bin/start-servers.sh
@@ -36,11 +36,11 @@ yarn start:shared-ganache | tee $E2E_ROOT/shared-ganache.log &
 
 yarn run wait-on -t $WAIT_ON_TIMEOUT -i $WAIT_ON_INTERVAL $MONOREPO_ROOT/.ganache-deployments/ganache-deployments-8545.json
 
-cd $PACKAGES/$APP 
-yarn start | tee $E2E_ROOT/$APP.log &
+cd $PACKAGES/$APP/build
+python -m SimpleHTTPServer 3000 | tee $E2E_ROOT/$APP.log &
 
-cd $PACKAGES/xstate-wallet
-yarn start | tee $E2E_ROOT/xstate-wallet.log &
+cd $PACKAGES/xstate-wallet/build
+python -m SimpleHTTPServer 3055 | tee $E2E_ROOT/xstate-wallet.log &
 
 cd $PACKAGES/simple-hub
 yarn hub:start:dev | tee $E2E_ROOT/hub.log &
@snario snario transferred this issue from statechannels/statechannels Jul 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant