Switch metrics back to Diagnostics #129
Merged
+91
−89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lalexgap
force-pushed
the
switch-to-diag
branch
from
b5b3fef to
9bba98e
Compare
|
The rationale for this change makes sense to me. The testground docs don't really give a clear steer on which API we ought to use, but the tradeoffs seem clear and worth making the change to diagnostics. Before approving: there are lots of seemingly unrelated changes on this PR. Are they intentional? |
Good catch! I think some changes were added via a rebase. I'll clean that up. |
lalexgap
force-pushed
the
switch-to-diag
branch
from
9bba98e to
ec295f2
Compare
geoknee
approved these changes
Nov 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #128
When using results (
runenv.R()) all the metrics are sent to the database at the end of the run. If the run is long this can be quite a large set of data, which fails to get sent to the database with the errorRequest Entity Too Large.This switches most of our metrics back to diagnostics (
runenv.D()) which immediately writes out to the database. The only metrics that are still posted toresultsare theci/nightlysummary metrics. Since these are summary metrics about the whole test run it seemed more appropriate for them to post to results.This does mean that most of the metrics are now excluded from the dashboard link on the tasks page. However the dashboard link is to a bunch of autogenerated graphs that aren't really useful, so I don't think that's a big loss.
TODO: