Fix rpcClient.Address() race condition #1607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy Preview for nitrodocs processing.
|
✅ Deploy Preview for nitro-gui canceled.
|
✅ Deploy Preview for nitro-storybook canceled.
|
kerzhner
approved these changes
Aug 29, 2023
| @@ -178,7 +178,7 @@ func main() { | |||
|
|
|||
| logging.SetupDefaultLogger(os.Stdout, slog.LevelDebug) | |||
|
|
|||
| node, _, _, _, err := node.InitializeNode(pkString, chainOpts, useDurableStore, durableStoreFolder, msgPort, os.Stdout, peerSlice) | |||
| node, _, _, _, err := node.InitializeNode(pkString, chainOpts, useDurableStore, durableStoreFolder, msgPort, peerSlice) | |||
There was a problem hiding this comment.
Just checking, but it seems like this change is unrelated to the race condition. Is that correct?
There was a problem hiding this comment.
Yes it is unrelated to the race condition. Just something I noticed when scanning through the code. Its related to the PR that was merged this morning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
rpcClient.Address()race condition that caused a CI failure when changes were merged intomain: https://github.com/statechannels/go-nitro/actions/runs/6012869180/job/16309076480