Fix patsy authentication code #1837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy Preview for nitrodocs processing.
|
✅ Deploy Preview for nitro-payment-demo canceled.
|
geoknee
commented
Nov 14, 2023
| DO_API_KEY: ${{ secrets.DO_API_KEY }}} | ||
| DO_API_KEY: ${{ secrets.DO_API_KEY }} |
There was a problem hiding this comment.
This typo means the deployment would never actually succeed, since the droplet would fail to authenticate with the container registry.
In fact this bug has been here since the existence of the action! So we haven't actually been deploying any code changes for the last two months https://github.com/statechannels/go-nitro/blame/main/.github/workflows/deploy-patsy.yml#L44.
Changes to configuration were being deployed, which made this easier to miss.
To follow up, we need to make sure the github action fails when the registry auth fails.
lalexgap
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.