Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: when using invoked actors in a top-level final state, error should be shown #3960

Open
hgezim opened this issue Apr 10, 2023 · 1 comment

Comments

@hgezim
Copy link

hgezim commented Apr 10, 2023

Description

I spent a lot of time debugging this issue. Had a final state with an invoked actor. It would start executing the invoked actor but not report any errors to onError.

Expected result

To see a warning or an error

Actual result

It let me shoot myself in the foot for a couple hours straight.

Reproduction

https://stately.ai/viz/42973d38-455d-44d5-93a9-8a8d323d5283

Additional context

No response

@hgezim hgezim added the bug label Apr 10, 2023
@davidkpiano
Copy link
Member

You're right; final states should not have invoked actors, which matches the SCXML spec: https://www.w3.org/TR/scxml/#final

We should warn against this and/or disallow this in v5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants