Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use consistent variable names #45

Open
stathismor opened this issue Dec 27, 2020 · 3 comments
Open

Use consistent variable names #45

stathismor opened this issue Dec 27, 2020 · 3 comments

Comments

@stathismor
Copy link
Owner

We need to have some consistency on how we call things across server/client. Things like name/username, player/user, etc.
@dbertella
Copy link
Collaborator

what do you propose?

@dbertella
Copy link
Collaborator

Is this still a thing?

@stathismor
Copy link
Owner Author

Yeah, definitely. Some inconsistencies I am aware of:
username/name
user/player
gameIO/socket
cardKey is probably a cardId
Some files are lowercase (games, rooms, etc) while we have Socket Server etc

I generally think at some point, when we're almost done, we can review all these, and even names etc, and rename.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stathismor @dbertella