Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sortIfNeeded in AbstractJoinOperation does't use the right Component reference #42

Open
hadrienk opened this issue Nov 6, 2017 · 1 comment

Comments

@hadrienk
Copy link

hadrienk commented Nov 6, 2017

The sortIfNeeded() method uses the wrong reference when building the Order. This is probably dues to the expression refactoring.

The sortIfNeeded uses the component mapping (this.getComponentMapping()) to find the correct component to use for the dataset. Either the mapping is wrong (but I think I created tests for it) or the component is mutated somewhere.

@hadrienk
Copy link
Author

I believe the problem comes from the join assignment operation. Since the assignment can change the component reference, the getData(...) method with Order parameters should be overridden.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant