Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor dependencies #28

Open
5 of 6 tasks
GregorDeCillia opened this issue May 27, 2020 · 1 comment
Open
5 of 6 tasks

Refactor dependencies #28

GregorDeCillia opened this issue May 27, 2020 · 1 comment
Assignees

Comments

@GregorDeCillia
Copy link
Contributor

GregorDeCillia commented May 27, 2020

  • dplyr: Only used once in the package (see below) so we could really remove the dependency altogether.
  • matrixStats: only used for matrixStats::rowProds. Should be removed completely
  • ggplot2: The plotting features are not very central for the package so we could move the dependency from Imports to Suggests
  • laeken: Used for example data (eusilc), gini() and weightedMedian(). Probably we should keep this dependency as-is. Otherwise, we would have to host our own copy of the laeken::eusilc data
  • Rcpp: Necessary
  • data.table: Necessary

eusilc[, ecoStat := dplyr::recode(

@GregorDeCillia GregorDeCillia added this to the 4th CRAN release milestone May 27, 2020
@GregorDeCillia GregorDeCillia self-assigned this May 27, 2020
GregorDeCillia added a commit that referenced this issue May 27, 2020
@GregorDeCillia
Copy link
Contributor Author

GregorDeCillia commented May 27, 2020

It turns out, changing ggplot2 to an optional dependency is not as easy as expected because of this

#' @import ggplot2

Namespace imports are not allowed for optional dependencies which means that quite some changes in R/plot.R would be necessary to implement this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant