Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Props constructor for watchShallow #30

Open
glorat opened this issue Jan 15, 2020 · 0 comments
Open

Props constructor for watchShallow #30

glorat opened this issue Jan 15, 2020 · 0 comments

Comments

@glorat
Copy link

glorat commented Jan 15, 2020

In the props

vue-plotly/src/Plotly.vue

Line 47 in 3f05b63

watchShallow: false,

Should be

            watchShallow: {
              type:Boolean,
              default: function() {
                return false
              }
            },

because props references types, not values. eslint picks up this bug

Happy to provide a PR for this if needed
@glorat glorat changed the title Props constructor Props constructor for watchShallow Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@glorat