Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Implement Distribution<u64> for Geometric #300

Closed
nielsle opened this issue Sep 23, 2024 · 1 comment
Closed

Feature request: Implement Distribution<u64> for Geometric #300

nielsle opened this issue Sep 23, 2024 · 1 comment

Comments

@nielsle
Copy link

nielsle commented Sep 23, 2024

The geometric distribution is an integer distribution, but the struct named Geometric implements Distribution<f64>.

It would be great to implement Distribution<u64> as well.

Links for reference:
https://docs.rs/statrs/latest/statrs/distribution/struct.Geometric.html
https://rust-random.github.io/rand/rand_distr/struct.Geometric.html

@YeungOnion
Copy link
Contributor

#155 implements this!

If you want it from crates.io, I'm the holdup for the release, wanting to get in the last major chunk of breaking changes we know about in this one. If you'd like to implement something that better handles low probability, that would be welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants