Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use the common CI workflow #233

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

use the common CI workflow #233

wants to merge 1 commit into from

Conversation

narimiran
Copy link
Contributor

No description provided.

@jangko
Copy link
Contributor

jangko commented Nov 28, 2024

It's not that this library not compatible with Nim 1.6 anymore but a problem in nim-websock. The problem have been fixed in nim-websock but tagged properly. I have fixed that too. Can you try once again with Nim 1.6 enabled?

@narimiran
Copy link
Contributor Author

narimiran commented Nov 28, 2024 •
edited
Loading

Can you try once again with Nim 1.6 enabled?

It seems the problem is still here.

Do I need to rebase this onto the latest commit in the master branch, or something else needs to be done?

My fault, I need to revert the change in the .nimble file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@narimiran @jangko