Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suspicious inconsistent behaviour between posix vs windows regarding server teardown #40

Open
jangko opened this issue May 27, 2021 · 3 comments

Comments

@jangko
Copy link
Contributor

jangko commented May 27, 2021

when writing tests for UTF8, I forget to insert tear down code like snippet below.

on windows it still run ok, but on linux it scream with addr in use.
I was expecting same behavior on both windows and posix os.

  var server: HttpServerRef
  let address = initTAddress("127.0.0.1:8888")

  suite "UTF-8 validator in action":
    teardown:
      await server.stop()
      await server.closeWait()
@dryajov
Copy link
Member

dryajov commented Jun 16, 2021

I believe this is now taken care of by the new http backend.

@jangko
Copy link
Contributor Author

jangko commented Jun 17, 2021

after take a closer look, it seems not a nim-ws problem. probably chronos or OS behavior.
nim-graphql http server also exhibit this behavior.

i think we can close this one.

@dryajov
Copy link
Member

dryajov commented Jun 17, 2021

Let's dig a little more, maybe this is a bug in chronos or maybe we're not closing something correctly. There is also another weird behavior described in #58, it might be related.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants