Skip to content

Commit b6feaf1

Browse files
authored
Clear some obsolete or wrong asserts (#3135)
why It is wrong to depend on a particular state of other modules (e.g. `FC` module) unless they are fully controlled by this one.
1 parent e2ae3fb commit b6feaf1

File tree

2 files changed

+0
-6
lines changed

2 files changed

+0
-6
lines changed

execution_chain/sync/beacon/worker/blocks_staged.nim

-1
Original file line numberDiff line numberDiff line change
@@ -363,7 +363,6 @@ proc blocksStagedImport*(
363363
finHash = if nBn < ctx.layout.final: nthHash
364364
else: ctx.layout.finalHash
365365

366-
doAssert nBn == ctx.chain.latestNumber()
367366
ctx.pool.chain.forkChoice(nthHash, finHash).isOkOr:
368367
ctx.poolMode = true
369368
warn info & ": fork choice error (reorg triggered)", n, iv,

execution_chain/sync/beacon/worker/headers_staged.nim

-5
Original file line numberDiff line numberDiff line change
@@ -116,9 +116,6 @@ proc headersStagedCollect*(
116116

117117
# End block: `fetchHeadersBody`
118118

119-
# The cache `antecedent` must match variable `D` (aka dangling)
120-
doAssert ctx.hdrCache.fcHeaderAntecedent().number <= ctx.layout.dangling
121-
122119
let nHeaders = nDeterministic + nOpportunistic.uint64
123120
if nHeaders == 0:
124121
return false
@@ -149,8 +146,6 @@ proc headersStagedProcess*(buddy: BeaconBuddyRef; info: static[string]) =
149146
let qItem = ctx.hdr.staged.le(high BlockNumber).valueOr:
150147
break # all done
151148

152-
doAssert qItem.key == qItem.data.revHdrs[0].number
153-
154149
let
155150
minNum = qItem.data.revHdrs[^1].number
156151
maxNum = qItem.data.revHdrs[0].number

0 commit comments

Comments
 (0)