Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement logging of go request and response #16414

Open
anastasiyaig opened this issue Sep 26, 2024 · 1 comment · May be fixed by #16808
Open

Implement logging of go request and response #16414

anastasiyaig opened this issue Sep 26, 2024 · 1 comment · May be fixed by #16808
Assignees
@igor-sirotin
Labels
core-team feature
Milestone
2.32.0 Beta

Comments

@anastasiyaig
Copy link
Contributor

Description

Similar to https://github.com/status-im/status-mobile/pull/21218/files
We need this on desktop side as well. Appears to be config in status-go (examples from mobile):

https://github.com/status-im/status-mobile/blob/5df1e6caf69306ddc0552fbf9f9cc7d7d971bff1/src/status_im/common/log.cljs#L28-L32

         logging-params {:enable?         true
                        :mobile-system?  false
                        :log-level       level
                        :log-request-go? config/log-request-go
                        :callback        handle-error}]

https://github.com/status-im/status-go/blob/a7daee3dae0cbad9549c7edc6cad9185caace27b/mobile/status.go#L1698-L1702

type InitLoggingRequest struct {
    logutils.LogSettings
    LogRequestGo   bool   `json:"LogRequestGo"`
    LogRequestFile string `json:"LogRequestFile"`
}

the only matter involving infra would be making it conditional in CI dependent on build type ( for example in https://github.com/status-im/status-jenkins-lib/blob/d745a2afda688097bfa8f876417646ef3210358f/vars/linux.groovy#L8)
@anastasiyaig
Copy link
Contributor Author

anastasiyaig commented Sep 26, 2024 •
edited
Loading

cc @antdanchenko @igor-sirotin @osmaczko

@anastasiyaig anastasiyaig added this to the 2.31.0 Beta milestone Sep 26, 2024
@jrainville jrainville modified the milestones: 2.31.0 Beta, 2.32.0 Beta Oct 21, 2024
@churik churik mentioned this issue Nov 11, 2024
Open
@igor-sirotin igor-sirotin self-assigned this Nov 11, 2024
This was referenced Nov 22, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@igor-sirotin igor-sirotin

Labels
core-team feature
Projects
Status Desktop/Mobile Board
Status: In Progress
Milestone
2.32.0 Beta
Development

Successfully merging a pull request may close this issue.

feat: status-go API logging option status-im/status-desktop
3 participants
@jrainville @igor-sirotin @anastasiyaig