feat(dapps): Add connector badge to WC and BC dapps #16816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexjba
requested review from
dlipicar and
Cuteivist
and removed request for
a team
2 tasks
Jenkins Builds
|
|
@alexjba what's the first ui in the video you used to test this please? |
|
caybro
approved these changes
Nov 26, 2024
| @@ -220,7 +220,7 @@ SQUtils.QObject { | |||
|
|
|||
| onConnectDApp: (chains, dAppUrl, dAppName, dAppIcon, key) => { | |||
| siwePlugin.connectionRequests.set(key.toString(), {chains, dAppUrl, dAppName, dAppIcon}) | |||
| root.connectDApp(chains, dAppUrl, dAppName, dAppIcon, key) | |||
| root.connectDApp(chains, dAppUrl, dAppName, dAppIcon, Constants.WalletConnect, key) | |||
There was a problem hiding this comment.
Suggested change
| root.connectDApp(chains, dAppUrl, dAppName, dAppIcon, Constants.WalletConnect, key) | |
| root.connectDApp(chains, dAppUrl, dAppName, dAppIcon, Constants.DAppConnectors.WalletConnect, key) |
| @@ -140,7 +140,7 @@ SQUtils.QObject { | |||
| function onSessionProposal(sessionProposal) { | |||
| const key = sessionProposal.id | |||
| d.activeProposals.set(key.toString(), { context: sessionProposal, promise: bcConnectionPromise }) | |||
| root.newConnectionProposed(key, [1], sessionProposal.params.proposer.metadata.url, sessionProposal.params.proposer.metadata.name, sessionProposal.params.proposer.metadata.icons[0]) | |||
| root.newConnectionProposed(key, [1], sessionProposal.params.proposer.metadata.url, sessionProposal.params.proposer.metadata.name, sessionProposal.params.proposer.metadata.icons[0], Constants.StatusConnect) | |||
There was a problem hiding this comment.
Suggested change
| root.newConnectionProposed(key, [1], sessionProposal.params.proposer.metadata.url, sessionProposal.params.proposer.metadata.name, sessionProposal.params.proposer.metadata.icons[0], Constants.StatusConnect) | |
| root.newConnectionProposed(key, [1], sessionProposal.params.proposer.metadata.url, sessionProposal.params.proposer.metadata.name, sessionProposal.params.proposer.metadata.icons[0], Constants.DAppConnectors.StatusConnect) |
virginiabalducci
approved these changes
Nov 26, 2024
Adding connector badge to the dapps list and connect modal Updating the RoundImageWithBadge to support custom badge size and margins Updating the RoundImageWithBadge to support both SVG and PNG as source Polish the dapps sign modal badge to match the design
alexjba
force-pushed
the
16815-browser-plugin-connector-add-the-connector-badge-to-dapp-icon
branch
from
dcf84a4
to
4c915e3
Compare
alexjba
deleted the
16815-browser-plugin-connector-add-the-connector-badge-to-dapp-icon
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do
Closes #16815
Affected areas
Wallet connect
Browser connect
Architecture compliance
My PR is consistent with this document: Status Desktop Architecture Guide
Screenshot of functionality (including design for comparison)
Screen.Recording.2024-11-26.at.12.52.56.mov