Skip to content

Commit

Permalink
debug: enable new arch, hermes for issues
Browse files Browse the repository at this point in the history
  • Loading branch information
siddarthkay committed Oct 3, 2024
1 parent d74530b commit e8dd70b
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -275,10 +275,10 @@ run-re-frisk: ##@run Start re-frisk server
run-android: export TARGET := android
# Disabled for debug builds to avoid 'maximum call stack exceeded' errors.
# https://github.com/status-im/status-mobile/issues/18493
run-android: export ORG_GRADLE_PROJECT_hermesEnabled := false
run-android: export ORG_GRADLE_PROJECT_universalApk := false
run-android: export ORG_GRADLE_PROJECT_hermesEnabled := true
# enabling new architecture requires hermes to be enabled
run-android: export ORG_GRADLE_PROJECT_newArchEnabled := false
run-android: export ORG_GRADLE_PROJECT_newArchEnabled := true
run-android: ##@run Build Android APK and start it on the device
@scripts/run-android.sh

Expand Down
4 changes: 2 additions & 2 deletions android/gradle.properties
Original file line number Diff line number Diff line change
Expand Up @@ -54,10 +54,10 @@ commitHash=unknown
# to write custom TurboModules/Fabric components OR use libraries that
# are providing them.
# enabling new architecture requires hermes to be enabled
newArchEnabled=false
newArchEnabled=true

# Use this property to enable or disable the Hermes JS engine.
# If set to false, you will be using JSC instead.
# Disabled for debug builds to avoid 'maximum call stack exceeded' errors.
# https://github.com/status-im/status-mobile/issues/18493
hermesEnabled=false
hermesEnabled=true

0 comments on commit e8dd70b

Please sign in to comment.