Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configure status-go to use Sentry #21656

Open
igor-sirotin opened this issue Nov 20, 2024 · 2 comments · May be fixed by #21682
Open

Configure status-go to use Sentry #21656

igor-sirotin opened this issue Nov 20, 2024 · 2 comments · May be fixed by #21682
Assignees
@ilmotta
Labels
feature feature requests mobile-core
Milestone
2.33.0

Comments

@igor-sirotin
Copy link
Contributor

igor-sirotin commented Nov 20, 2024 •
edited
Loading

Feature Request

What's need to be done:

  1. When building status-go, set these environment variables:
    • SENTRY_CONTEXT_NAME="status-mobile"
    • SENTRY_CONTEXT_VERSION=<mobile-version-here>
  2. Set requests.InitializeApplication.sentryDSN parameter to the value stored in SENTRY_DSN_STATUS_MOBILE environment variable.
    It will be provided by CI in release builds.
    You can use any other env var variable name, but let infra team know in Setup Sentry secrets on CI status-desktop#16842.

User Story

As a developer, I want to receive Sentry crash reports for the panics in status-go.

Acceptance Criteria

  1. Run status-mobile
  2. Make some action that leads to a panic in status-go (just hardcode something for testing purposes)
    NOTE: for now only these panics are reported:
    • In /mobile/status.go endpoints
    • In any goroutines
  3. Able to see the crash report at sentry.infra.status.im

Notes

  1. Sentry is integrated here (not merged yet):
  2. Desktop example here:
  3. CI is not yet configured to provide environment variables. We're doing it.
  4. To get access to Sentry, ping @markoburcul
@igor-sirotin igor-sirotin added the feature feature requests label Nov 20, 2024
@igor-sirotin igor-sirotin mentioned this issue Nov 20, 2024
Merged
@ilmotta ilmotta self-assigned this Nov 22, 2024
@ilmotta ilmotta moved this to In Progress in Status Desktop/Mobile Board Nov 22, 2024
@ilmotta ilmotta linked a pull request Nov 26, 2024 that will close this issue
Draft
@ilmotta ilmotta added this to the 2.32.0 milestone Dec 3, 2024
@ilmotta ilmotta modified the milestones: 2.32.0, 2.33.0 Dec 12, 2024
@churik
Copy link
Member

churik commented Jan 28, 2025

@ilmotta let me know if I can assist with this one with testing

@ilmotta
Copy link
Contributor

ilmotta commented Jan 28, 2025

@ilmotta let me know if I can assist with this one with testing

Thanks @churik! @siddarthkay made some fixes recently, so I will be re-testing the PR this week #21682. In terms of testing @churik, I can test it myself as I've been doing so far, if that helps. I'll let you know once everything is working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ilmotta ilmotta

Labels
feature feature requests mobile-core
Projects
Status Desktop/Mobile Board
Status: In Progress
Milestone
2.33.0
Development

Successfully merging a pull request may close this issue.

Configure Sentry for Mobile status-im/status-mobile
3 participants
@ilmotta @churik @igor-sirotin