Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bench: add missing native.js and fix variable range #6467

Merged
merged 2 commits into from
Apr 1, 2025
Merged

bench: add missing native.js and fix variable range #6467

merged 2 commits into from
Apr 1, 2025
+76 −6

Conversation

anandkaranubc
Copy link
Contributor

Resolves none.

Description

What is the purpose of this pull request?

This pull request:

  • adds the missing native file and fix variable range

Related Issues

Does this pull request have any related issues?

This pull request:

  • resolves none

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@anandkaranubc
bench: add missing native file and fix variable range
5263e01 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@stdlib-bot stdlib-bot added Math Issue or pull request specific to math functionality. Needs Review A pull request which needs code review. labels Mar 31, 2025
anandkaranubc
anandkaranubc commented Mar 31, 2025
View reviewed changes
lib/node_modules/@stdlib/math/base/special/negalucas/benchmark/benchmark.js
@@ -40,7 +40,7 @@ bench( pkg, function benchmark( b ) {
var y;
var i;

x = discreteUniform( 100, -77, 0 );
x = discreteUniform( 100, -76, 0 );
Copy link
Contributor Author

@anandkaranubc anandkaranubc Mar 31, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

discreteUniform returns values inclusive of both the minimum and maximum.

cc: @hrshya

Reference PR: #6430

@stdlib-bot
Copy link
Contributor

stdlib-bot commented Mar 31, 2025 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
math/base/special/negalucas $\color{green}221/221$
$\color{green}+100.00\%$ 		$\color{green}11/11$
$\color{green}+100.00\%$ 		$\color{green}2/2$
$\color{green}+100.00\%$ 		$\color{green}221/221$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@anandkaranubc
Copy link
Contributor Author

/stdlib merge

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Apr 1, 2025
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Apr 1, 2025
@anandkaranubc anandkaranubc added Benchmarks Pull requests adding or improving benchmarks for measuring performance. JavaScript Issue involves or relates to JavaScript. labels Apr 1, 2025
kgryte
kgryte approved these changes Apr 1, 2025
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for circling back on this, @anandkaranubc!

@kgryte kgryte removed the Needs Review A pull request which needs code review. label Apr 1, 2025
@kgryte kgryte merged commit 3425c5a into stdlib-js:develop Apr 1, 2025
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte approved these changes

Assignees
No one assigned
Labels
Benchmarks Pull requests adding or improving benchmarks for measuring performance. JavaScript Issue involves or relates to JavaScript. Math Issue or pull request specific to math functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anandkaranubc @stdlib-bot @kgryte