stylish start page #10
Conversation
|
That looks great! I’m concerned about all the extra code that’s required for it though. We would either need to add those code changes to the guide or let the example repo be different than the guide. |
|
i mean you can have something like import "./styles.css";
import $ from "jquery";
let content = `<div class="content">
<img id="logo" src="//stealjs.com/img/steal-landing-page-logo.jpg">
<p class="quote">Futuristic JavaScript dependency loader and builder</p>
</div>`;
$('.container').html(content);instead |
|
👍 to the shortened version. |
styles.css
Outdated
| vertical-align: middle; | ||
| } | ||
| .content { | ||
| text-align: center; |
There was a problem hiding this comment.
Can this be removed since .container has text-align: center?
|
@chasenlehara made some changes and accept your review. feel free to merge |
index.js
Outdated
| $(document.body).append("<h1>Hello World!</h1>"); | ||
| let content = ` | ||
| <div class="content"> | ||
| <img id="logo" src="//stealjs.com/img/steal-landing-page-logo.jpg"> |
There was a problem hiding this comment.
Let’s use this SVG so it looks nice on high-DPI screens: http://stealjs.com/docs/static/node_modules/bit-docs-docjs-theme/static/img/StealJS-Logo-V2.svg
I’m going to make the same change on the home page: stealjs/stealjs#30
use svg steal logo
what do you think about a nice looking startpage ?