Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store the full contents of top-level package.json files? #81

Open
blink1073 opened this issue Oct 23, 2015 · 4 comments
Open

Store the full contents of top-level package.json files? #81

blink1073 opened this issue Oct 23, 2015 · 4 comments

Comments

@blink1073
Copy link

Would you be amenable to storing the full package.json Object for the top level modules under System.npm, as opposed to the current stub? We end up re-fetching the top level package.json files to get pertinent information in our app.

@justinbmeyer
Copy link
Contributor

Thanks for posting. I don't think we should to this by default because some package.json's can get quite large. However, I think a flag that turns this on is reasonable. Something like:

system: {
  includePackageProperties: true,
  includePackageProperties: ["property1","property2"]
}

where true would pull in everything, but you could also specify certain properties too.

@blink1073
Copy link
Author

Yep, sounds fair.

@matthewp
Copy link
Member

What do you mean by "top level modules"? You mean the app's own package.json or more than that?

@blink1073
Copy link
Author

I meant the app's package.json and that of any direct dependencies.

@matthewp matthewp added the p4 label Oct 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants