Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Sentry issue if we fail to create a file #117

Open
ssawchenko opened this issue Aug 1, 2023 · 2 comments
Open

Create Sentry issue if we fail to create a file #117

ssawchenko opened this issue Aug 1, 2023 · 2 comments
Assignees

Comments

@ssawchenko
Copy link
Collaborator

We will want to be careful that we are not reporting this TOO frequently such that we overwhelm our Sentry limit. We may want to keep track of if we have reported this issue during the App lifetime and only report it once?

@ssawchenko ssawchenko self-assigned this Aug 14, 2023
@phileo
Copy link

phileo commented Aug 15, 2023

will also be helpful to know if Sentry.captureEvent(fileAttachment) failed as well

reference:
https://steamclock.slack.com/archives/CQCEV6YBU/p1692121100482689?thread_ts=1692110239.806389&cid=CQCEV6YBU

@ssawchenko
Copy link
Collaborator Author

ssawchenko commented Aug 15, 2023

will also be helpful to know if Sentry.captureEvent(fileAttachment) failed as well

reference: https://steamclock.slack.com/archives/CQCEV6YBU/p1692121100482689?thread_ts=1692110239.806389&cid=CQCEV6YBU

Good idea, I'll add in a report for that as well.

Update: Dug into this a little further - sounds like in Daniel's case the entire Sentry report isn't being sent. I'm not sure if we can check to see if the Sentry event was properly sent to Sentry or not... ie. I don't think we can simply wrap that call in a try/catch as I believe Sentry batches up reports to send asynchronously.

I can check to see if we have failed to attach files to a user report though, and log a separate crash report for that, but that seems like a different edge case then Daniel is talking about here.

Since doing either of these things is a little larger in scope, I will split this comment out into a separate ticket so that we can move forward with first having Steamclog report on bad file paths: #121

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants