Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching to decorateMarkerLayer for the decorations #601

Open
aminya opened this issue Dec 11, 2020 · 1 comment
Open

Switching to decorateMarkerLayer for the decorations #601

aminya opened this issue Dec 11, 2020 · 1 comment
Labels

Comments

@aminya
Copy link
Collaborator

aminya commented Dec 11, 2020

Copied from: https://github.com/atom-minimap/minimap-find-and-replace/issues/20

this.textEditor.decorateMarker(marker, {

When searching for common strings in a large file, clearing the search can take a long time because of the onDidDestroy listeners registered on individual markers. Currently, Atom itself uses these listeners, but when atom/atom#13516 lands, we will no longer need them, which will significantly improve the responsiveness of find-and-replace.

As part of testing that PR, I fired up this package, and I noticed that it prevents the performance improvement from taking affect because it also uses decorateMarker with individual markers. Have you looked into switching to the more performant TextEditor.decorateMarkerLayer API?

@aminya
Copy link
Collaborator Author

aminya commented Dec 22, 2020

This does not seem to be possible. Each marker relates to a separate linter message. We can't group them into a layer.

@aminya aminya added wontfix and removed enhancement labels Jan 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant