From c633fe263efa3353e7a15d9429c8dbaab7836da0 Mon Sep 17 00:00:00 2001 From: Amin Yahyaabadi Date: Fri, 5 Mar 2021 14:24:31 -0600 Subject: [PATCH] fix: make the functions that are without any promises sync --- lib/toggle-view.ts | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/lib/toggle-view.ts b/lib/toggle-view.ts index e87a6135..4d1320a7 100644 --- a/lib/toggle-view.ts +++ b/lib/toggle-view.ts @@ -22,13 +22,13 @@ export default class ToggleProviders { }), ) } - async getItems(): Promise> { + getItems(): Array { if (this.action === 'disable') { return this.providers.filter(name => !this.disabledProviders.includes(name)) } return this.disabledProviders } - async process(name: string): Promise { + process(name: string): void { if (this.action === 'disable') { this.disabledProviders.push(name) this.emitter.emit('did-disable', name) @@ -40,12 +40,12 @@ export default class ToggleProviders { } atom.config.set('linter.disabledProviders', this.disabledProviders) } - async show() { + show() { if (!SelectListView) { SelectListView = require('atom-select-list') } const selectListView = new SelectListView({ - items: await this.getItems(), + items: this.getItems(), emptyMessage: 'No matches found', elementForItem: (item: any) => { const li = document.createElement('li') @@ -53,9 +53,12 @@ export default class ToggleProviders { return li }, didConfirmSelection: (item: any) => { - this.process(item) - .catch(e => console.error('[Linter] Unable to process toggle:', e)) - .then(() => this.dispose()) + try { + this.process(item) + this.dispose() + } catch(e) { + console.error('[Linter] Unable to process toggle:', e) + } }, didCancelSelection: () => { this.dispose()