Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Optimize for lighthouse results #15

Merged
merged 4 commits into from
Sep 18, 2023
Merged

Feat: Optimize for lighthouse results #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a9d3a3a
style: Fix anchors color contrast
steezplusplus Sep 18, 2023
f1a22cd
fix: Add proper aria labels
steezplusplus Sep 18, 2023
8247e03
feat: Prioritize img to reduce LCP measurement
steezplusplus Sep 18, 2023
27a5210
Merge branch 'main' of https://github.com/steezplusplus/steezplusplus…
steezplusplus Sep 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion app/_components/cards/music-card/audio.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,11 @@ export function Audio(props: AudioProps) {
Your browser does not support the <code>audio</code> element.
</audio>
<div className="flex rounded border border-slate-400 px-2 py-1">
<button className="h-full border-r px-2" onClick={togglePlayPause}>
<button
className="h-full border-r px-2"
onClick={togglePlayPause}
aria-label={`${isPlaying ? 'Pause' : 'Play'} the audio`}
>
{isPlaying ? <Pause size={16} /> : <Play size={16} />}
</button>
<div className="flex w-full items-center gap-x-1 px-3">
Expand All @@ -51,6 +55,7 @@ export function Audio(props: AudioProps) {
min="0"
value={volume}
onChange={(e) => setVolume(Number(e.target.value))}
aria-label="Adjust the volume"
/>
</div>
</div>
Expand Down
1 change: 1 addition & 0 deletions app/_components/cards/profile-card/profile-card.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ export function ProfileCard() {
>
<div className="flex h-full flex-col items-center justify-center">
<Image
priority
src="/primary.jpg"
alt="A profile picture"
width="128"
Expand Down
6 changes: 5 additions & 1 deletion app/_components/cards/repo-card/repo-card.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,11 @@ export function RepoCard(props: RepoCardProps) {

<div className="flex flex-col items-center">
<Link
className="text-blue-500 underline hover:text-blue-300"
className="
mt-6 text-blue-700
underline hover:text-blue-900
dark:text-purple-400 dark:hover:text-purple-600
"
href={githubUrl}
target="_blank"
>
Expand Down
6 changes: 5 additions & 1 deletion app/_components/footer/footer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,11 @@ export function Footer() {
</li>
<li>
<Link
className="text-blue-500 underline hover:text-blue-300"
className="
mt-6 text-blue-700
underline hover:text-blue-900
dark:text-purple-400 dark:hover:text-purple-600
"
href={githubRepoUrl}
target="_blank"
>
Expand Down
9 changes: 8 additions & 1 deletion app/not-found.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,14 @@ export default function NotFound() {
<div className="flex flex-col items-center justify-center">
<h2 className="mb-1 text-lg">This page doesn&apos;t exist!</h2>
<p className="text-sm">I&apos;m not sure how you got here.</p>
<Link className="mt-6 text-2xl text-blue-500 underline hover:text-blue-300" href="/">
<Link
className="
mt-6 text-2xl text-blue-900
underline hover:text-blue-700
dark:text-purple-400 dark:hover:text-purple-600
"
href="/"
>
Go back
</Link>
</div>
Expand Down