Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"File Cashing" #77

Open
vladisoc opened this issue Apr 20, 2021 · 3 comments
Open

"File Cashing" #77

vladisoc opened this issue Apr 20, 2021 · 3 comments

Comments

@vladisoc
Copy link

I found a nasty bug related to some cashing I guess.
Scenario:

  1. Load a file
  2. Modify file with another program
  3. Reopen file in vs code

The hex is the same, modifications are not visible
Also a nice feature would be to move nibble and width settings to right click context menu
@James-Dengel
Copy link

I can confirm that I can reproduce this:

Version: 1.56.0
Commit: cfa2e218100323074ac1948c885448fdf4de2a7f
Date: 2021-05-04T22:06:21.189Z (6 days ago)
Electron: 12.0.4
Chrome: 89.0.4389.114
Node.js: 14.16.0
V8: 8.9.255.24-electron.0
OS: Darwin x64 20.3.0

Plugin Version: 1.8.1

@jakeypoo
Copy link

Same issue here. Restarting VS Code window solved it.

Version: 1.57.0 (user setup)
Commit: b4c1bd0a9b03c749ea011b06c6d2676c8091a70c
Date: 2021-06-09T17:18:42.354Z
Electron: 12.0.9
Chrome: 89.0.4389.128
Node.js: 14.16.0
V8: 8.9.255.25-electron.0
OS: Windows_NT x64 10.0.19041

Plugin Version: 1.8.1

rom-p added a commit to rom-p/vscode-hexdump that referenced this issue Dec 20, 2021
@rom-p
correctly handling tab closure (essentially fixing bug stef-levesque#77)
c0c9ae9 
before this change, the list of known files always grew.  Meaning if the file is closed, its data persisted in the memory, but wasn't updated when it was updated externally.  Fixed it two ways: first, re-reading the whole file on every change, and removing the file from `_files` on tab closure
@rom-p
Copy link

rom-p commented Dec 20, 2021

noticed that GitHub automatically inserted the comment above. Cool.

I intend to send PR for this and other changes from my branch, once I fix the editing issues

@rom-p rom-p mentioned this issue Dec 21, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jakeypoo @vladisoc @James-Dengel @rom-p