junit5 compatible version

[davidkarlsen]

Would it be possible to alter the rule so that @EnableRuleMigrationSupport would work: https://medium.com/@GalletVictor/migration-from-junit-4-to-junit-5-d8fe38644abe

• or better - make it an Extension?

[davidkarlsen]

Linking stefanbirkner/system-rules#55

[stefanbirkner]

I would like to avoid implementing ExternalResource because the migration support is only a hack that relies on a contract that is not really given (although it works for almost all rules that implement ExternalResource).

According to your comment in stefanbirkner/system-rules#55 the only problem why you cannot replace the rule with stefanbirkner/fake-sftp-server-lambda is that you need the port information before the Spring extension starts the application. Am I right?

[davidkarlsen]

Correct

[stefanbirkner]

How did you set the port for the SpringRunner with JUnit 4?

[davidkarlsen]

private static final String DHUB_ENDPOINT_PROPERTY = "dhub.sftp.endpoint";

    @ClassRule
    public static final FakeSftpServerRule sftpServer = new FakeSftpServerRule();

    @AfterAll
    public static void afterClass() {
        System.clearProperty(DHUB_ENDPOINT_PROPERTY);
    }

    @BeforeAll
    public static void beforeClass() {
        System.setProperty(DHUB_ENDPOINT_PROPERTY, "localhost:" + sftpServer.getPort());
    }

[stefanbirkner]

I have a workaround for the lambda solution

private static final int String SFTP_SERVER_PORT = freePort();

@AfterAll
public static void afterClass() {
    System.clearProperty(DHUB_ENDPOINT_PROPERTY);
}

@BeforeAll
public static void beforeClass() {
    System.setProperty(DHUB_ENDPOINT_PROPERTY, "localhost:" + SFTP_SERVER_PORT);
}

@Test
void aTest() {
    withSftpServer(server -> {
        //your code
    });
}

private withSftpServer(
    FakeSftpServer.ExceptionThrowingConsumer testCode
) throws Exception {
    FakeSftpServer.withSftpServer(server -> {
        server.setPort(SFTP_SERVER_PORT);
        testCode.accept(server);
    });
}

private static freePort() {
    try (ServerSocket socket = new ServerSocket(0)) {
        return socket.getLocalPort();
    } catch (IOException e) {
        throw new RuntimeException(
            "Failed to find a free port.",
            e
        );
    }
}

Instead of the method freePort you may also use Spring's SocketUtils.findAvailableTcpPort().

[sbrannen]

Glad you guys found a work-around! 🎉

[sbrannen]

And... I can also highly recommend Spring's SocketUtils (I promise: no personal bias).

[davidkarlsen]

It worked fine. Closing