Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unused variables #370

Open
mitul93 opened this issue Aug 22, 2022 · 3 comments
Open

Unused variables #370

mitul93 opened this issue Aug 22, 2022 · 3 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@mitul93
Copy link

mitul93 commented Aug 22, 2022

Describe the bug

Following variables are unused and can be removed.

frm_obs in lambda thread_right

std::thread thread_right([this, &frm_obs, &right_img_gray, &mask, &keypts_right, &descriptors_right]() {

variable ini_extractor_left_

feature::orb_extractor* ini_extractor_left_ = nullptr;

variable bow_db_

data::bow_database* bow_db_ = nullptr;

data::bow_database* bow_db_ = nullptr;

variable bow_vocab_

data::bow_vocabulary* bow_vocab_;

variable fix_scale_in_Sim3_estimation_

const bool fix_scale_in_Sim3_estimation_;

variable this

auto add_second_local_keyframe = [this, &second_local_keyfrms, &already_found_keyfrm_ids](const std::shared_ptr<data::keyframe>& keyfrm) {

variable frame_hash_

To Reproduce

The unused variable can be checked by searching them in the vscode or any other editor.

Expected behavior

Not Applicable

Screenshots or videos

Not Applicable

Environment

  • Hardware: PC
  • CPU: i7-12700
  • OS: Ubuntu 22.04
  • Commit id: a404f57
@mitul93 mitul93 added the bug Something isn't working label Aug 22, 2022
@ymd-stella
Copy link
Contributor

LGTM

@ymd-stella ymd-stella added the good first issue Good for newcomers label Aug 22, 2022
@annavordou
Copy link

I'm interested in working on this isssue. Could you kindly provide some more information?

@ymd-stella
Copy link
Contributor

Simply delete unused variables.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants