Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional Mapping configuration #531

Open
AlejandroSilvestri opened this issue Sep 5, 2023 · 0 comments
Open

Optional Mapping configuration #531

AlejandroSilvestri opened this issue Sep 5, 2023 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@AlejandroSilvestri
Copy link

As for version 0.4.0, all configuration parameters except for Camera node have default values, leading to much smaller configuration files. But stella_vslam fails to run if you entirely omit the Mapping node in yaml file.
It works if you just add "Mapping:", without any actual mapping configuration.
It's a very minimal bug.
This is the line causing the error:

mapper_ = new mapping_module(cfg_->yaml_node_["Mapping"], map_db_, bow_db_, bow_vocab_);

I believe it can be fixed by changing the first argument for:

mapper_ = new mapping_module(util::yaml_optional_ref(cfg_->yaml_node_, "Mapping"), map_db_, bow_db_, bow_vocab_);

Not tested, I am sorry I don't pull a request.

@AlejandroSilvestri AlejandroSilvestri added the bug Something isn't working label Sep 5, 2023
@ymd-stella ymd-stella added the good first issue Good for newcomers label Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants