Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance bankswitching classes for debugging #536

Closed
thrust26 opened this issue Sep 7, 2019 · 1 comment
Closed

Enhance bankswitching classes for debugging #536

thrust26 opened this issue Sep 7, 2019 · 1 comment
Assignees
@thrust26
Labels
debugger enhancement
Milestone
Prio 2

Comments

@thrust26
Copy link
Member

thrust26 commented Sep 7, 2019 •
edited
Loading

Several bankswitching classes do not implement methods required for debugging. E.g. getBank() and bankCount() are not implemented, because they are "too complex". Affected classes:

  • CartridgeE0
  • Cartridge3EPlus
  • Cartridge4A50
  • CartridgeDASH

Also, since there can be more than one 4K slice with different banks switched in, the debugger would need information about each slice. This affects more classes, e.g. CartridgeE7 and Cartridge3E. Cartridge currently has no such methods.

Note: This affects #512.
@thrust26 thrust26 self-assigned this Sep 7, 2019
@thrust26 thrust26 added this to the Prio 2 milestone Sep 7, 2019
thrust26 added a commit that referenced this issue Sep 7, 2019
@thrust26
Add considering addresses for current bank. This is important for typ…
d7c4b1a 
…es where the 4K ROM address space is segmented into smaller slices, so there can be more than one bank at a time.

This addresses #536.
@thrust26
Copy link
Member Author

I suppose this is sufficient for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thrust26 thrust26

Labels
debugger enhancement
Projects
None yet
Milestone
Prio 2
Development

No branches or pull requests
1 participant
@thrust26