Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

Remove wrap token language #716

Closed
leighmcculloch opened this issue Feb 12, 2024 · 2 comments · Fixed by #718
Closed

Remove wrap token language #716

leighmcculloch opened this issue Feb 12, 2024 · 2 comments · Fixed by #718
Labels
bug Something in our docusaurus site isn't working documentation (fix) Reword, clarify, add to, remove, etc. bits of content that already exist

Comments

@leighmcculloch
Copy link
Contributor

leighmcculloch commented Feb 12, 2024

The docs discuss the concept of wrapping tokens, but this concept is old from long ago and no longer part of the vocabulary we or others should be using to talk about deploying Stellar Asset contracts.

The CLI token wrap command was made deprecated a while ago in stellar/stellar-cli#934 and replaced with asset deploy command.

I think the area of docs that need updating is at least this page:

https://github.com/stellar/soroban-docs/blob/ab6b117bf1e9c1fa8ad8ec3199f9fa954c36f687/docs/guides/cli/wrap-token.mdx#L6-L10

@leighmcculloch
Copy link
Contributor Author

When we update this guide to refer to the asset deployment command I think we need to add explanations of each argument, and what they mean.

There is some feedback in Discord that it is not intuitive:

https://discord.com/channels/897514728459468821/966788672164855829/1205869799343788032

@leighmcculloch leighmcculloch added bug Something in our docusaurus site isn't working documentation (fix) Reword, clarify, add to, remove, etc. bits of content that already exist labels Feb 12, 2024
@tupui
Copy link
Contributor

tupui commented Feb 12, 2024

Thanks! I am working on a suggestion, will have this shortly up and we can discuss on the PR 😃

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something in our docusaurus site isn't working documentation (fix) Reword, clarify, add to, remove, etc. bits of content that already exist
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants