Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split up dependencies into Peer Dependencies. #239

Closed
shanzzam opened this issue Dec 8, 2020 · 2 comments
Closed

Split up dependencies into Peer Dependencies. #239

shanzzam opened this issue Dec 8, 2020 · 2 comments
Assignees
@piyalbasu

Comments

@shanzzam
Copy link
Contributor

shanzzam commented Dec 8, 2020

Coming out of @fnando upgrade fixes, we saw a lot of dependencies https://github.com/stellar/account-viewer-next/pull/223/files

Suggestion from @morleyzhi and nando is to split these into peer dependencies.
@quietbits quietbits self-assigned this Dec 8, 2020
@shanzzam shanzzam assigned piyalbasu and unassigned quietbits Dec 9, 2020
@shanzzam shanzzam mentioned this issue Jan 5, 2021
Open
@shanzzam shanzzam closed this as completed Jan 5, 2021
@shanzzam
Copy link
Contributor Author

shanzzam commented Jan 5, 2021

Issue moved to stellar/js-stellar-wallets #194 via ZenHub

@shanzzam
Copy link
Contributor Author

shanzzam commented Jan 5, 2021 •
edited
Loading

Moved to the correct repo per @piyalbasu and @morleyzhi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@piyalbasu piyalbasu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@shanzzam @piyalbasu @quietbits @stellar-terraform