From 3a31ed780c580e4d9419ebda5532c1c16748f432 Mon Sep 17 00:00:00 2001
From: Prit Sheth <124409873+psheth9@users.noreply.github.com>
Date: Fri, 14 Jun 2024 16:40:01 -0700
Subject: [PATCH] Expose captive core version details (#5332)

* Expose captive core version details

* Log error instead of terminating the process

* Fetch core-version using stellar-core version

* fix formatting

* Fix review comments

* Use log from config
---
 ingest/ledgerbackend/captive_core_backend.go | 39 ++++++++++++++++++--
 1 file changed, 36 insertions(+), 3 deletions(-)

diff --git a/ingest/ledgerbackend/captive_core_backend.go b/ingest/ledgerbackend/captive_core_backend.go
index 25b22d01d5..9dfc82ac02 100644
--- a/ingest/ledgerbackend/captive_core_backend.go
+++ b/ingest/ledgerbackend/captive_core_backend.go
@@ -6,6 +6,8 @@ import (
 	"fmt"
 	"net/http"
 	"os"
+	"os/exec"
+	"strings"
 	"sync"
 	"time"
 
@@ -110,8 +112,9 @@ type CaptiveStellarCore struct {
 	lastLedger         *uint32 // end of current segment if offline, nil if online
 	previousLedgerHash *string
 
-	config            CaptiveCoreConfig
-	stellarCoreClient *stellarcore.Client
+	config             CaptiveCoreConfig
+	stellarCoreClient  *stellarcore.Client
+	captiveCoreVersion string // Updates when captive-core restarts
 }
 
 // CaptiveCoreConfig contains all the parameters required to create a CaptiveStellarCore instance
@@ -200,6 +203,7 @@ func NewCaptive(config CaptiveCoreConfig) (*CaptiveStellarCore, error) {
 	}
 
 	c.stellarCoreRunnerFactory = func() stellarCoreRunnerInterface {
+		c.setCoreVersion()
 		return newStellarCoreRunner(config)
 	}
 
@@ -211,7 +215,7 @@ func NewCaptive(config CaptiveCoreConfig) (*CaptiveStellarCore, error) {
 			URL: fmt.Sprintf("http://localhost:%d", config.Toml.HTTPPort),
 		}
 	}
-
+	c.setCoreVersion()
 	return c, nil
 }
 
@@ -245,6 +249,35 @@ func (c *CaptiveStellarCore) coreVersionMetric() float64 {
 	return float64(info.Info.ProtocolVersion)
 }
 
+// By default, it points to exec.Command, overridden for testing purpose
+var execCommand = exec.Command
+
+// Executes the "stellar-core version" command and parses its output to extract
+// the core version
+// The output of the "version" command is expected to be a multi-line string where the
+// first line is the core version in format "vX.Y.Z-*".
+func (c *CaptiveStellarCore) setCoreVersion() {
+	versionCmd := execCommand(c.config.BinaryPath, "version")
+	versionOutput, err := versionCmd.Output()
+	if err != nil {
+		c.config.Log.Errorf("failed to execute stellar-core version command: %s", err)
+	}
+
+	// Split the output into lines
+	rows := strings.Split(string(versionOutput), "\n")
+	if len(rows) == 0 || len(rows[0]) == 0 {
+		c.config.Log.Error("stellar-core version not found")
+		return
+	}
+
+	c.captiveCoreVersion = rows[0]
+	c.config.Log.Infof("stellar-core version: %s", c.captiveCoreVersion)
+}
+
+func (c *CaptiveStellarCore) GetCoreVersion() string {
+	return c.captiveCoreVersion
+}
+
 func (c *CaptiveStellarCore) registerMetrics(registry *prometheus.Registry, namespace string) {
 	coreSynced := prometheus.NewGaugeFunc(
 		prometheus.GaugeOpts{