From e56e346faf9d4288c09b8260f85a4d6a290aa280 Mon Sep 17 00:00:00 2001 From: Shawn Reuland Date: Mon, 26 Aug 2024 12:43:15 -0700 Subject: [PATCH] #4538: updated CHANGELOGs --- ingest/CHANGELOG.md | 8 ++++++++ ingest/ledgerbackend/run_from.go | 2 -- services/horizon/CHANGELOG.md | 3 +++ 3 files changed, 11 insertions(+), 2 deletions(-) diff --git a/ingest/CHANGELOG.md b/ingest/CHANGELOG.md index ed168de74e..7671573d73 100644 --- a/ingest/CHANGELOG.md +++ b/ingest/CHANGELOG.md @@ -1,5 +1,13 @@ # Changelog +## Pending + +### Fixed +* The Captive Core backend now performs 'online' stellar-core `run` for bounded modes of tx-meta retrieval. Refer to [runFrom.go](./ledgerbackend/run_from.go). Enables core to build, validate, and emit trusted ledger hashes in tx-meta stream from lastest of network for a bounded ledger range. The bounded mode will no longer do the 'offline' mode of running core `catchup` for getting tx-meta from just history archives, which does not guarantee verification of the ledger hashes to that of live network. ([#4538](https://github.com/stellar/go/pull/4538)). + * Note - due to the usage of `run` with LCL set to the `from` , there is now potential for longer run time execution durations due to core having to perform online replay from network latest ledger back to `from`. The longer runtime duration will be proportional to the older age of the `from` ledger. + + + All notable changes to this project will be documented in this file. This project adheres to [Semantic Versioning](http://semver.org/). ### Stellar Core Protocol 21 Configuration Update: diff --git a/ingest/ledgerbackend/run_from.go b/ingest/ledgerbackend/run_from.go index e22c316b02..3c5961118c 100644 --- a/ingest/ledgerbackend/run_from.go +++ b/ingest/ledgerbackend/run_from.go @@ -26,8 +26,6 @@ type runFromStream struct { // from - the ledger sequnce to start streaming additional ledgers there after // fromHash - the hash of from ledger // runnerMode - stellarCoreRunnerModePassive or stellarCoreRunnerModeActive -// -// core toml settings, such as for offline, it will disable http port of core as it's not needed. func newRunFromStream(r *stellarCoreRunner, from uint32, fromHash string, runnerMode stellarCoreRunnerMode) (runFromStream, error) { // Use ephemeral directories on windows because there is // no way to terminate captive core gracefully on windows. diff --git a/services/horizon/CHANGELOG.md b/services/horizon/CHANGELOG.md index 5d1990ed17..7aa080315a 100644 --- a/services/horizon/CHANGELOG.md +++ b/services/horizon/CHANGELOG.md @@ -8,6 +8,9 @@ file. This project adheres to [Semantic Versioning](http://semver.org/). ### Fixed - Horizon: not passing trusted hash to captive-core when configured to run catchup "on disk" ([4538](https://github.com/stellar/go/pull/4538)) + * The Captive Core backend now performs 'online' stellar-core `run` for bounded modes of tx-meta retrieval, which will be used for `db reingest range` and `ingest verify-range` commands. Enables core to build, validate, and emit trusted ledger hashes in tx-meta stream for the requested ledger range. These bounded range commands will no longer do the 'offline' mode of running core `catchup` for getting tx-meta from just history archives, which does not guarantee verification of the ledger hashes to that of live network. ([#4538](https://github.com/stellar/go/pull/4538)). + * Note - due to the usage of `run` with LCL set to the `from` , there is now potential for longer run time `reingest` and `verify-range` execution durations due to core having to perform online replay from network latest ledger back to `from`. The longer runtime duration will be proportional to the older age of the `from` ledger. + ## 2.32.0