Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exp/services/recoverysigner: reduce duplicate authentication and account conversion code #2324

Closed
leighmcculloch opened this issue Feb 26, 2020 · 1 comment

Comments

@leighmcculloch
Copy link
Member

The recoverysigner has duplicate authentication and account conversion code. We should think about ways to reduce the code so that the core of what is happening is more apparent.

Note: I don't think we should reduce the duplication if there is no clean way to do so, or if it makes the code horribly more complex.

@leighmcculloch leighmcculloch self-assigned this Feb 26, 2020
@leighmcculloch leighmcculloch changed the title Recoverysigner: Reduce duplicate authentication and account conversion code exp/services/recoverysigner: Reduce duplicate authentication and account conversion code Feb 28, 2020
@leighmcculloch leighmcculloch changed the title exp/services/recoverysigner: Reduce duplicate authentication and account conversion code exp/services/recoverysigner: reduce duplicate authentication and account conversion code Feb 28, 2020
@leighmcculloch leighmcculloch removed their assignment Apr 13, 2020
@mollykarcher
Copy link
Contributor

Closing all recoverysigner issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants