Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exp/services/recoverysigner: improve logs and alerts #2358

Closed
4 tasks
leighmcculloch opened this issue Mar 4, 2020 · 1 comment · Fixed by #2567
Closed
4 tasks

exp/services/recoverysigner: improve logs and alerts #2358

leighmcculloch opened this issue Mar 4, 2020 · 1 comment · Fixed by #2567
Assignees
@leighmcculloch

Comments

@leighmcculloch
Copy link
Member

leighmcculloch commented Mar 4, 2020 •
edited
Loading

Logs to add:

  • Any action the results in a db operation (insert, update, delete).
  • Each successful or unsuccessful authentication (the unsuccessful case might be something to remove if we see a lot of them)
  • Each successful transaction signed including the transaction hash in the log

Alerts to add:

  • Any error resulting in a 500 being returned to the client.
@leighmcculloch leighmcculloch self-assigned this Mar 4, 2020
@leighmcculloch leighmcculloch removed their assignment Mar 18, 2020
@leighmcculloch leighmcculloch mentioned this issue Mar 23, 2020
Merged
7 tasks
@leighmcculloch leighmcculloch self-assigned this Apr 1, 2020
@leighmcculloch leighmcculloch mentioned this issue Apr 25, 2020
Merged
7 tasks
leighmcculloch added a commit that referenced this issue Apr 29, 2020
@leighmcculloch
exp/services/webauth: capture challenge and verification process in l…
b281376 
…ogs (#2506)

### What
Add logs that capture the challenge and verification process and will show for a single request the path taken and approximately why verification has failed.

### Why
To aid with debugging in situations where there are reports of verification failure that a client believes are in error. I started taking a look at #2358 which is adding logs and alerts to recoverysigner and it looks like we also need to do this in webauth so I'm starting here.
@leighmcculloch leighmcculloch changed the title exp/services/recoverysigner: improve logs and alerts exp/services/{webauth,recoverysigner}: improve logs and alerts Apr 29, 2020
@leighmcculloch leighmcculloch changed the title exp/services/{webauth,recoverysigner}: improve logs and alerts exp/services/recoverysigner: improve logs and alerts Apr 29, 2020
This was referenced May 7, 2020
Merged
Closed
@leighmcculloch
Copy link
Member Author

#2567 resolves this issue, and I've opened #2568 for a specific improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leighmcculloch leighmcculloch

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

exp/services/recoverysigner: add basic logs
1 participant
@leighmcculloch