Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exp/services/recoverysigner: add tests for the KMS client #2750

Closed
howardtw opened this issue Jun 26, 2020 · 2 comments
Closed

exp/services/recoverysigner: add tests for the KMS client #2750

howardtw opened this issue Jun 26, 2020 · 2 comments

Comments

@howardtw
Copy link
Contributor

We use these mocks to test to mock out the call to the kms client. However, we don't currently have a way to test the kms client in cmd/keyset.go. It's fairly important to test the tool as it's critical to make sure we can use the kms client without any problem when encryption-kms-key-uri is provided. Without the took working properly, we cannot start the recovery signer in a secure way.

Similarly, we don't have a way to exercise the code path when a valid kms key uri is provided here.

@leighmcculloch
Copy link
Member

Here's an idea for what we could do using the local-kms tool:

recoverysigner-unique-signing-keys...recoverysigner-unique-signing-keys-kms-tests

@leighmcculloch leighmcculloch changed the title exp/services/recoverysigner: think about the strategy to test the KMS client exp/services/recoverysigner: add tests for the KMS client Jul 11, 2020
@leighmcculloch leighmcculloch removed their assignment Oct 27, 2020
@mollykarcher
Copy link
Contributor

Closing all recoverysigner issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants