exp/services/recoverysigner: remove urlencoded form decoding from requests #3331
Comments
leighmcculloch
referenced
this issue
in stellar/stellar-protocol
Jan 11, 2021
…equests (#800) ### What Remove urlencoded form data as a accepted content-type in requests. ### Why @JakeUrban pointed out how there is really no consistent standard for encoding complex nested data in urlencoded form, which means that integrations are highly likely to use it, or to be buggy. We started using dual content types in requests in SEP-10 and we applied that broadly here but the difficulty to use is compelling that this isn't going to have a positive return on investment to maintain and isn't a pattern we should propogate to other SEPs either. Related conversation in #790. This change is breaking but the proposal is in draft and that is acceptable. It is also unlikely that there are implementations using form encoding given the difficult to provide that feature. The recoverysigner reference implementation can be updated to remove the urlencoded form data decoding, but it doesn't have to be to continue to meet the standard. When we have time we can update it. I have created https://github.com/stellar/stellar-protocol/issues/801 to track that work.
This comment has been minimized.
This comment has been minimized.
|
Closing all recoverysigner issues |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What
Remove urlencoded form decoding from requests.
Why
It is being removed from SEP-30: stellar/stellar-protocol#800.
The text was updated successfully, but these errors were encountered: