-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
services/soroban-rpc: Spike to try running horizon & soroban-rpc together in a quickstart container #4590
Comments
Is the quickstart container referencing http://github.com/stellar/quickstart? That image would be the ideal place to do this I think, as it already has all the foundation for running nodes, horizon, friendbot, captive-core, etc. |
For an example for how to add a new service to the quickstart image, see this change where we added friendbot recently: stellar/quickstart@f7fe34c (Note that the change there is bigger than what you actually need to do because that change also introduced nginx that sits in front of all HTTP services exposed by the container, but you don't need to add nginx.) |
@paulbellamy , wanted to confirm usage of they are referring to same instance of core/network hosted in quickstart image or different? |
The quickstart image supports 3 networks out of the box today:
I imagine we will add another option similar to the first two that is soroban-rpc should be able to work with the others, like |
@leighmcculloch , thanks, I'll start looking into quickstart repo per your suggestions, I think have confirmed the expected outcome of the image/container on #4554 chat to support the dev use case from there: |
@leighmcculloch @paulbellamy @tamirms I've posted PR draft with changes in quickstart to modify the image and include latest version of soroban-rpc by @tamirms for getAccount, which dropped usage of captive core/ingest, instead using horizon api, the modified quickstart container looks stable, I put soroban-rpc behind quickstart's nginx, and was able to invoke |
@leighmcculloch @paulbellamy , wanted to check with you on how 'futurenet' network could be used with this image, can that be accomplished as-is with |
@sreuland We need to add a command line option that configures all of the applications to point to futurenet in the same way we already have the I wouldn't go the route of relying on |
@leighmcculloch , thanks for confirm, do you know where I could obtain a sample of core.cfg file for We want to allow captive core mode in the image |
Futurenet doesn't exist yet, and the command line options in the quickstart image need to be added for it. I don't think there is an issue for this work, so I just created: stellar/quickstart#368. |
ok, the effort to support |
As a short-term solution, having soroban-rpc proxy to a horizon server would be a quicker way for us to build
getAccount
functionality (#4556).We want devs to be able to run a local standalone network (and run soroban-rpc locally pointed at futurenet). This will be done via the
quickstart
docker image.However, I am concerned that both horizon and soroban-rpc running captive-core in the same docker image will conflict. The spike here is to see if that causes issues, or if it just works.
The text was updated successfully, but these errors were encountered: