-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTTP Setup: Default WriteTimeout #4785
Comments
We discussed this, and came to the conclusion we need to take a more careful look at our existing timeouts to make sure we use the right default WriteTimeout. Ideally, this should be longer than all our existing timeouts, but not unlimited like it currently is. Moved back to our backlog for now. |
Fyi this was something we investigated previously. There are some findings here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What problem does your feature solve?
There is no default
WriteTimeout
in the setup of http server. If the server instance is used using a configuration withoutWriteTimeout
it will be set to 0 which meansno timeout
. That may be an issue if a request takes too much time to process and can potentially lead to DoS the server.We need to be careful how this value is set though. It should be more than ReadTimeout.
Those two articles provide useful information in my opinion:
What would you like to see?
A default value for
WriteTimeout
in HTTP setup functionWhat alternatives are there?
We already have a default
ReadTimeout
and Go >= 1.13 sets a pretty aggressive TCP timeout, so this may be sufficient if our services does not let the client control parameters that influence the processing time of a request. But it is good practice in case there is a edge case.The text was updated successfully, but these errors were encountered: