Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Horizon: account streaming should send an event when account is created/merged #736

Closed
andrenarchy opened this issue Oct 30, 2018 · 3 comments
Closed

Horizon: account streaming should send an event when account is created/merged #736

andrenarchy opened this issue Oct 30, 2018 · 3 comments
Labels
good first issue help wanted horizon horizon-api Issues or features related to the Horizon API

Comments

@andrenarchy
Copy link

When streaming a non-existing account the connection is currently closed immediately with a 404. It'd be nice if the endpoint could keep the connection alive and send an event when the account is created (same for when it's removed/merged). Currently we need to poll the account endpoint for that which is not ideal.
@bartekn bartekn mentioned this issue Jan 14, 2019
Closed
@bartekn bartekn modified the milestones: Horizon v0.16.0, Horizon next minor release Jan 22, 2019
@bartekn bartekn assigned howardtw and unassigned howardtw Jan 29, 2019
@bartekn bartekn removed this from the Horizon next minor release milestone Jan 29, 2019
@poliha
Copy link
Contributor

poliha commented Feb 1, 2019

One way around this might be to stream for effects and filter out the account id that you are interested in

@ire-and-curses ire-and-curses added the horizon-api Issues or features related to the Horizon API label Jul 19, 2019
@chasen-bettinger
Copy link

Is this the StreamEffects function in effect_request.go? I'm having trouble finding where the code related to this ticket is.

@ire-and-curses ire-and-curses added the Hacktoberfest https://hacktoberfest.digitalocean.com/details label Sep 30, 2019
@bartekn bartekn mentioned this issue May 6, 2020
Closed
@ire-and-curses ire-and-curses removed the Hacktoberfest https://hacktoberfest.digitalocean.com/details label May 6, 2020
@bartekn bartekn removed the small fix label Dec 20, 2021
@Rishabh-1126
Copy link

Can I work on this issue

@mollykarcher mollykarcher removed the P2 label Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue help wanted horizon horizon-api Issues or features related to the Horizon API
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
9 participants
@bartekn @tomquisel @ire-and-curses @mollykarcher @andrenarchy @poliha @howardtw @chasen-bettinger @Rishabh-1126