Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate finding vulnerabilities in dependencies in Horizon + SDKs #848

Closed
tomquisel opened this issue Jan 31, 2019 · 3 comments
Closed

Comments

@tomquisel
Copy link
Contributor

Keeping Horizon + SDKs secure is extremely important.

We should set up npm audit (for JS) and similar tools to run automatically during our workflow. Maybe an automated daily checker is the way to go. @brahman81 do you have any checkers like this already set up for other projects?

@MarinX
Copy link

MarinX commented Mar 4, 2019

I use SonarQube
It provides a nice report and solution for common mistakes.

For example, running stellar-go project, it shows:

@brahman81
Copy link
Contributor

@tomquisel apart from Githubs vulnerability Alerts, we do not have anything like this in place but @MarinX 's suggestion of SonarQube looks promising.

It would be interesting to evaluate other solutions, GH maintains a page with alternatives:

https://github.com/marketplace/category/security

@vcarl
Copy link
Contributor

vcarl commented Mar 6, 2019

Snyk and SourceClear look promising, very similar to npm audit in that they check dependencies for known issues (vs scanning code).

gosec also looks to be a linter for security vulnerabilities, doesn't seem to be related to dependencies. I'm skeptical of scanning code for vulnerabilities though. I know "fuzzing" is a powerful way to test for issues (security and otherwise), may be worth investigating further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants