Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is captive-core not working in mainnet or pubnet in stellar-quickstart? #467

Closed
sj602 opened this issue Jul 10, 2023 · 4 comments · Fixed by #486
Closed

Why is captive-core not working in mainnet or pubnet in stellar-quickstart? #467

sj602 opened this issue Jul 10, 2023 · 4 comments · Fixed by #486
Assignees
Labels

Comments

@sj602
Copy link

sj602 commented Jul 10, 2023

What version are you using?

stellar-core: 19.11.0
horizon: 2.25.0

What did you do?

I wanted to run stellar-quickstart docker image for testnet in captive-core mode, using this command
sudo docker run --rm -it -p 8000:8000 -v /home1/irteamsu/stellar:/opt/stellar -e PGPASS=stellar -e PGPASS_CONFIRMATION=stellar --name stellar stellar/quickstart --testnet --enable-horizon-captive-core
But I found that the start script in the image is coded that it only works for standalone or futurenet in captive-core mode(refer to: https://github.com/stellar/quickstart/blob/master/start#L36)
Why is that? is that a bug or a right instruction?

What did you expect to see?

What did you see instead?

@sj602 sj602 added the bug label Jul 10, 2023
@github-actions
Copy link

github-actions bot commented Aug 9, 2023

This issue is stale because it has been open for 30 days with no activity. It will be closed in 30 days unless the stale label is removed.

@github-actions github-actions bot added the stale label Aug 9, 2023
@leighmcculloch
Copy link
Member

According to git the captive-core functionality for standalone was added by @2opremio:

@2opremio do you remember why we limited captive-core to standalone?

@leighmcculloch
Copy link
Member

Reading between the lines this comment in Slack might suggest we added it for standalone only because that's all we needed it on at the time because we were adding it to support using quickstart in integration tests with captive-core in use. Thread is here:

@sj602
Copy link
Author

sj602 commented Sep 13, 2023

OK. I see.
But I want to use captive-core in stellar-quickstart. Do you guys have any plans for deleting the limitation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants